Ticket #8 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

[PATCH] Caching breaks for untranslated strings resulting in many db queries

Reported by: olivier Assigned to: saimonmoore
Priority: critical Milestone: rails-1.3
Component: view Version:
Keywords: Cc:

Description

I believe there was a bug in the view translation cache code that stopped it from actually working properly (Although this was maybe a few months ago). I remember applying a patch which helped significantly reduce the number of database selects.

Ah I found the patch in question, and have attached the emails that were sent to the list.

Bonne

Attachments

db_view.logging.diff (2.8 kB) - added by olivier on 11/03/06 08:38:42.
PATCH with login
db_view.no_logging.diff (1.1 kB) - added by olivier on 11/03/06 08:39:25.
PATCH no logging

Change History

11/03/06 08:38:42 changed by olivier

  • attachment db_view.logging.diff added.

PATCH with login

11/03/06 08:39:25 changed by olivier

  • attachment db_view.no_logging.diff added.

PATCH no logging

11/03/06 08:40:20 changed by olivier

  • summary changed from Cache/Memcache to [PATCH] Cache/Memcache.

11/04/06 13:29:40 changed by olivier

  • status changed from new to closed.
  • resolution set to invalid.

The patch only stop to increment the cache queries counter, which is not a database select number indicator but the number of time we requested on the cache Hash.

04/28/07 02:44:23 changed by jsierles

  • status changed from closed to reopened.
  • summary changed from [PATCH] Cache/Memcache to [PATCH] Caching breaks for untranslated strings resulting in many db queries.
  • resolution deleted.
  • milestone changed from rails-1.1 to rails-1.2.

I'm not sure what the previous comment meant, but this patch does effectively fix the caching problem. It should get applied or refactored.

04/30/07 08:44:07 changed by saimonmoore

  • owner changed from olivier to saimonmoore.
  • status changed from reopened to new.
  • milestone changed from rails-1.2 to rails-1.3.

04/30/07 08:44:50 changed by saimonmoore

  • status changed from new to closed.
  • resolution set to fixed.

Patch applied (refactored for namespaces) to my personal branch which will soon make it's way into trunk.